[libcxx-commits] [PATCH] D115177: [libc++] [ranges] SFINAE-friendly "write it three times" in views::counted.

Joe Loser via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 6 12:52:48 PST 2021


jloser added inline comments.


================
Comment at: libcxx/include/__ranges/counted.h:48
+      noexcept(noexcept(span(_VSTD::to_address(__it), static_cast<size_t>(__count))))
+      // Deliberately omit return-type SFINAE, because to_address is not SFINAE-friendly
+      { return          span(_VSTD::to_address(__it), static_cast<size_t>(__count)); }
----------------
Should `to_address` be SFINAE friendly instead? I vaguely remember running into this in a PR a few months ago (https://reviews.llvm.org/D108855).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115177/new/

https://reviews.llvm.org/D115177



More information about the libcxx-commits mailing list