[libcxx-commits] [PATCH] D115125: [libc++] Avoid rejection sampling in `uniform_int_distribution` if possible

Fabian Wolff via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Dec 6 11:48:13 PST 2021


fwolff abandoned this revision.
fwolff added a comment.

In D115125#3172432 <https://reviews.llvm.org/D115125#3172432>, @Quuxplusone wrote:

> My initial reaction is that this change slows down the common case to cater to a really super pathological case; I don't think we should do it (but a benchmark could probably change my mind).

OK. This was just a suggestion because there was a bug report about this, and the check definitely gets optimized away for all "common" cases, but I understand your concern.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115125/new/

https://reviews.llvm.org/D115125



More information about the libcxx-commits mailing list