[libcxx-commits] [PATCH] D99913: [SystemZ][z/OS] Modify cxxabi to be compatible with existing z/OS runtime

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D99913#3174140 <https://reviews.llvm.org/D99913#3174140>, @MaskRay wrote:

> (In a trip; having limited Internet connection)
> Drive-by comment:
> AIUI `_Unwind_` is the https://itanium-cxx-abi.github.io/cxx-abi/abi-eh.html namespace but also used by some GCC extensions.
> Defining a `_Unwind_` identifier may have potential for a conflict with libgcc if they aren't informed.

I guess they could add `_UnwindZOS_PopException` when building LLVM's libunwind on z/OS.

Nonetheless, I think the "building with an external libunwind" approach is fine, but we should do it properly, not with ad-hoc `include_directories` and introducing a new CMake variable that only works on z/OS.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99913/new/

https://reviews.llvm.org/D99913