[libcxx-commits] [PATCH] D115100: [libc++] Enable the optimized _IsSame on GCC as well as Clang.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone added inline comments.


================
Comment at: libcxx/include/type_traits:936
 
+struct __two {char __lx[2];};
+
----------------
jloser wrote:
> Why move this below the `// is_class` comment? It's a standalone helper type unrelated to `is_class` AFAICT, right? I recommend moving it above the `// is_class` comment. Maybe even add the `// helper class:` comment above the `struct __two {char __lx[2];};`.
> 
> Alternatively, revert the diff entirely as it's not needed for this patch. :)
`is_class` is the first one who needs it, although yeah this was path-dependent and I should just move it below the old `// helper class:` comment. (Not sure how it wound up above it in the first place, and haven't looked.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115100/new/

https://reviews.llvm.org/D115100