[libcxx-commits] [PATCH] D114001: [libc++][format] WIP Adds formatter floating-point.

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/benchmarks/formatter_float.bench.cpp:91
+    // std::numeric_limits<F>::max() - -std::numeric_limits<F>::max()
+    std::uniform_real_distribution<F> distribution(-std::numeric_limits<F>::max() / F(2.1),
+                                                   std::numeric_limits<F>::max() / F(2.1));
----------------
File a bug report about this issue when GitHub issues are activated.
cppreference https://en.cppreference.com/w/cpp/numeric/random/uniform_real_distribution
has a link to https://hal.archives-ouvertes.fr/hal-03282794/document
a better way to get the proper distribution.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114001/new/

https://reviews.llvm.org/D114001