[libcxx-commits] [PATCH] D114912: [libc++] [P1614] Hidden-friend operator<=> for string_view.

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 391517.
Quuxplusone marked 5 inline comments as done.
Quuxplusone added a comment.

Review comments.
Eliminate inheritance from `char_traits<char>` (it wasn't that many lines after all, once I dropped unnecessary constexprness).
I'd missed "Mandates: `R` denotes a comparison category type," so now there's a `static_assert` with that message and a `.verify.cpp` test to verify the message.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114912/new/

https://reviews.llvm.org/D114912

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__compare/comp_cat.h
  libcxx/include/__compare/ordering.h
  libcxx/include/__string
  libcxx/include/module.modulemap
  libcxx/include/string_view
  libcxx/test/libcxx/diagnostics/detail.headers/compare/comp_cat.module.verify.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/spaceship.pass.cpp
  libcxx/test/std/strings/string.view/string.view.comparison/spaceship_mandates.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D114912.391517.patch
Type: text/x-patch
Size: 24915 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20211203/ef09ea6e/attachment-0001.bin>