[libcxx-commits] [PATCH] D114985: [libc++][NFC] Disable clang-tidy checks

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

In D114985#3167951 <https://reviews.llvm.org/D114985#3167951>, @ldionne wrote:

> In D114985#3167911 <https://reviews.llvm.org/D114985#3167911>, @cjdb wrote:
>
>> Why is `llvm-else-after-return` disabled? That's a pretty important readability improvement. What about `llvm-header-guard`?
>
> IIUC  `llvm-else-after-return` is the thing that tries to remove any `else` after an `if` that contains a return? IMO that's not a readability improvement at all, at least not in the places where it modified the code in D114915 <https://reviews.llvm.org/D114915>.

I found a lot of the changes to improve readability, but the `__libcpp_is_constant_evaluated` ones were dubious and I can see why we should disable it for the time being.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114985/new/

https://reviews.llvm.org/D114985