[libcxx-commits] [PATCH] D113244: Simplify the libcxx std::string_view gdb pretty printer

[David Blaikie via Phabricator via libcxx-commits]

dblaikie added inline comments.


================
Comment at: libcxx/utils/gdb/libcxx/printers.py:261
+          return ptr.lazy_string(length=size)
+      return data.string(length=size)
 
----------------
saugustine wrote:
> dblaikie wrote:
> > halyavin wrote:
> > > What is `data`? Should it be `ptr`? 
> > Ah, indeed - thanks for the catch.
> > 
> > Separate conversation probably needs to be had about whether we need to support gdb's from 10 years ago that don't support lazy_string (I don't think we do).
> No need to hold this over, just never had a reason to clean it up before.
Skipped the conditional lazy_string stuff in this instance in this commit. Followup commit 1f2492b7daf64065129d35f2078c42898e84157f addressed the only other use of the conditional lazy_string thing here, for StdStringPrinter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113244/new/

https://reviews.llvm.org/D113244