[libcxx-commits] [PATCH] D114985: [libc++][NFC] Disable clang-tidy checks

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 2 12:54:09 PST 2021


ldionne added a comment.

In D114985#3167911 <https://reviews.llvm.org/D114985#3167911>, @cjdb wrote:

> Why is `llvm-else-after-return` disabled? That's a pretty important readability improvement. What about `llvm-header-guard`?

IIUC  `llvm-else-after-return` is the thing that tries to remove any `else` after an `if` that contains a return? IMO that's not a readability improvement at all, at least not in the places where it tried changing it in D114915 <https://reviews.llvm.org/D114915>.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114985/new/

https://reviews.llvm.org/D114985



More information about the libcxx-commits mailing list