[libcxx-commits] [PATCH] D114915: [libc++][NFC] Address clang-tidy warnings in include/

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

I'm happy with the few places that only re-format existing code in obvious ways, but anything where we change `else if` into `if` or things like that, I don't think it improves the code. I also think removing `{` and `}` from single-statement `if`s is not really a plus in most cases that I've seen in this patch.



================
Comment at: libcxx/.clang-tidy:2
 InheritParentConfig: true
-Checks: '-readability-identifier-naming'
+Checks: '-readability-identifier-naming,-llvm-header-guard,-llvm-include-order,-misc-unconventional-assign-operator'
----------------
Quuxplusone wrote:
> I don't know if we're close to consensus one way or the other on the if-else/early-return refactorings, but IMHO this one-line diff in the `.clang-tidy` file is now uncontroversial and can be landed ASAP if you want. (Someone +1 that?)
Yeah, +1 on adding this part. All the rest of the patch, I don't think much of it is an improvement over what we had before.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114915/new/

https://reviews.llvm.org/D114915