[libcxx-commits] [PATCH] D114920: [libc++] Re-enable `uniform_int_distribution<bool>`.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Dec 2 11:08:13 PST 2021


ldionne added a comment.

In D114920#3167060 <https://reviews.llvm.org/D114920#3167060>, @Quuxplusone wrote:

>> Let's just *not* support uniform_int_distribution<bool>, and make it into a static_assert.
>
> Works for me, but (1) I'll feel better once we hear from @leonardchan, and (2) what do you want to do about `char`, `signed char`, `char16_t`, etc.? Also disallow them via `static_assert`, I'd guess?

Yeah, I'd do the same. If something is library UB and it's easy to diagnose, I would diagnose it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114920/new/

https://reviews.llvm.org/D114920



More information about the libcxx-commits mailing list