[libcxx-commits] [PATCH] D113244: Simplify the libcxx std::string_view gdb pretty printer

Wed Dec 1 08:51:36 PST 2021

dblaikie added a comment.

In D113244#3164560 <https://reviews.llvm.org/D113244#3164560>, @ldionne wrote:

> In D113244#3164541 <https://reviews.llvm.org/D113244#3164541>, @dblaikie wrote:
>
>> Hmm, seems to have failed again in a similar way?
>
> Are you rebased on top of latest `main`? There was a bug where we entered an infinite loop a couple weeks ago, this could be the culprit if your tree is really old.

Best of my knowledge, yes. Presumably something in phab should describe what this patch is based on? Under "Revision Contents > Commits" it shows that this is based on 196204c72c68 <https://reviews.llvm.org/rG196204c72c68a577c72af95d70f18e3550939a5e> which was pushed yesterday, so far as I can tell?

> I strongly suggest you try running it locally like I outlined in my previous comment, that will be the simplest way of troubleshooting this. As much as I want to help (and will provide you the tools to troubleshoot it yourself), I don't have bandwidth to do it for you (which would imply doing it for all contributors).

When the infrastructure gives a fairly unactionable result that seems like an infrastructure problem, though? Perhaps the infrastructure isn't picking up the appropriate base to test this revision on?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113244/new/

https://reviews.llvm.org/D113244