[libcxx-commits] [PATCH] D109011: [libc++] [P0919] Some belated review on D87171

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone created this revision.
Quuxplusone added reviewers: ldionne, rarutyun.
Quuxplusone added a project: libc++.
Quuxplusone requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

A comment today on D87171 <https://reviews.llvm.org/D87171> made me look at it, and then I made a bunch of review comments before finally noticing that it was shipped ages ago. 😛 Well, rather than let my comments go to waste, here's the gist of them.

- Simplify the structure of the new tests.
- Test const containers as well as non-const containers, since it's easy to do so.
- Remove redundant enable-iffing of helper structs' member functions. (They're not instantiated unless they're called, and who would call them?)
- Drive-by: `_LIBCPP_INLINE_VISIBILITY` on some `swap` functions where I don't see why it was missing in the first place.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D109011

Files:
  libcxx/include/map
  libcxx/include/unordered_map
  libcxx/test/std/containers/unord/unord.map/contains.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.map/count.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.map/equal_range.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.map/equal_range_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.map/equal_range_non_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.map/find.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.map/find_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.map/find_non_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/contains.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/count.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/equal_range.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/equal_range_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/equal_range_non_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/find.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/find_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multimap/find_non_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/contains.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/count.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/equal_range.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/equal_range_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/equal_range_non_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/find.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/find_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.multiset/find_non_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.set/contains.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.set/count.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.set/equal_range.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.set/equal_range_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.set/equal_range_non_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.set/find.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.set/find_const.transparent.pass.cpp
  libcxx/test/std/containers/unord/unord.set/find_non_const.transparent.pass.cpp
  libcxx/test/support/is_transparent.h
  libcxx/test/support/test_transparent_unordered.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D109011.369753.patch
Type: text/x-patch
Size: 87840 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210831/b67c2748/attachment-0001.bin>