[libcxx-commits] [PATCH] D109011: [libc++] [P0919] Some belated review on D87171
Ruslan Arutyunyan via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Tue Aug 31 13:21:56 PDT 2021
rarutyun added inline comments.
================
Comment at: libcxx/test/std/containers/unord/unord.map/equal_range.transparent.pass.cpp:31
+ using M = unord_map_type<std::unordered_map, transparent_hash, std::equal_to<>>;
+ test_transparent_equal_range<M>({{1, 2}, {2, 3}});
+ test_transparent_equal_range<const M>({{1, 2}, {2, 3}});
----------------
I don't mind to combine `const` and non-`const` overloads of API into one file. I don't recall why I decided to make them separate. I believe there was some precedence in tests already and I made it for the sake of consistency but I cannot tell for sure.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109011/new/
https://reviews.llvm.org/D109011
More information about the libcxx-commits
mailing list