[libcxx-commits] [PATCH] D103357: [libc++][format] Add __format_arg_store.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 31 11:32:43 PDT 2021


ldionne added a comment.

I read the comments and while I am not a big fan of reimplementing `std::variant`, I understand why it's needed (unless we want to break `std::variant`'s ABI, which we don't). Also, this needs to make progress so I'm approving it -- worst case I can request some post-commit changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103357/new/

https://reviews.llvm.org/D103357



More information about the libcxx-commits mailing list