[libcxx-commits] [PATCH] D107835: [libunwind] Compile with -Wunused-but-set-variable

[David Blaikie via Phabricator via libcxx-commits]

dblaikie added a comment.

In D107835#2975142 <https://reviews.llvm.org/D107835#2975142>, @danielkiss wrote:

>> But I'd object more to adding extra warnings per project without a pretty significant reason that one subproject should differ from others.
>
> Flag is added here to have some regression check for the unused variables as this issue come up not just for me.
> I'd keep the flag here until it is enable globally.

I'm not sure I understand - what do you mean by "regression" - causing a build to fail because that build had the warning enabled already? Or you mean introducing code that has set-but-unused variables, but without any build failures?

I'd prefer we not enable this warning only for one subproject like this - divergence between subprojects increases maintenance burden and developer flexibility when moving between subprojects.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107835/new/

https://reviews.llvm.org/D107835