[libcxx-commits] [PATCH] D107835: [libunwind] Compile with -Wunused-but-set-variable

[David Blaikie via Phabricator via libcxx-commits]

dblaikie added a comment.

In D107835#2974586 <https://reviews.llvm.org/D107835#2974586>, @danielkiss wrote:

> In D107835#2948054 <https://reviews.llvm.org/D107835#2948054>, @dblaikie wrote:
>
>> any chance this can inherit flag settings from llvm, so we can make such configuration choices in one place?
>
> `-Wunused-but-set-variable` just added to unwind to be sure warnings won't come back. I don't see where it might cause problems. IIRC global runtime flags will be included in uninwd's cflags.

Sorry, I'm having trouble understanding what you mean - could you rephrase/use a few more words? (if the flag isn't added to libunwind, the warnings wouldn't come back because the warning wouldn't be enabled? The problems I have is that maintaining different flag sets in different subprojects (even if they're only additive) is more work/creates an inconsistent experience across subprojects compared to having all the flags selected in llvm proper so they're consistently used by all subprojects)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107835/new/

https://reviews.llvm.org/D107835