[libcxx-commits] [PATCH] D108856: [libcxx][docs] Remove completed issues from TODO.TXT

Tue Aug 31 06:50:03 PDT 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D108856#2973329 <https://reviews.llvm.org/D108856#2973329>, @jloser wrote:

> In D108856#2972654 <https://reviews.llvm.org/D108856#2972654>, @ldionne wrote:
>
>> I agree that we should eventually remove this file, however I'd rather do it gradually while making sure that the stuff it mentions has been addressed properly.
>>
>> I'm fine with this once the `std::allocator` thing has been addressed (LWG 2447). Until then, requesting changes.
>>
>> Regardless, thanks a lot for the cleanup.
>
> LWG 2447 is marked complete according to the issues docs <https://github.com/llvm/llvm-project/blob/30dfd3449e45ac371012c6e46c77ab9089496d4e/libcxx/docs/Status/Cxx17Issues.csv#L88>. I agree with you though that it doesn't seem to be implemented. I'll keep the LWG 2447 note in this `TODO.txt`, but I think we should also unmark it as `Complete` in the docs linked previously. Want me to do that in this diff or a separate patch?

Let's ship this, but you can open a separate patch so we can look at what needs to be done for LWG 2447. Thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108856/new/

https://reviews.llvm.org/D108856