[libcxx-commits] [PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D107799#2969650 <https://reviews.llvm.org/D107799#2969650>, @MaskRay wrote:

> @ldionne
>
> [...]
>
> The root cause is that `libcxx/test/configs/libcxx-trunk-shared.cfg.in` does not recognize the `-DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on` include and lib hierarchy.

Thanks for the analysis. I saw your other patch to fix libc++'s test suite harness (D108836 <https://reviews.llvm.org/D108836>). I think this patch should be OK once that has been resolved.

> Note that `libcxx/utils/libcxx/test/config.py` has some -I/-L/`-Wl,-rpath,` logic as well. `libcxx/test/configs/libcxx-trunk-shared.cfg.in` appears to duplicate some configuration there.

Yeah, it's a bit confusing but basically we're migrating from `config.py` to the smaller `libcxx/test/configs/libcxx-trunk-shared.cfg.in` files. It's a gradual transition.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107799/new/

https://reviews.llvm.org/D107799