[libcxx-commits] [PATCH] D70631: Microsoft's floating-point to_chars powered by Ryu and Ryu Printf

Mon Aug 30 17:36:49 PDT 2021

jorgbrown added a comment.

In D70631#2973239 <https://reviews.llvm.org/D70631#2973239>, @ldionne wrote:

> In D70631#2577688 <https://reviews.llvm.org/D70631#2577688>, @Mordante wrote:
>
>> @ldionne should we enabling floating point support by a CMake configuration option which is ON by default. The tables aren't small and it could add bloat for embedded devices.
>
> Hmm, for now I'd make them available everywhere, and in the future, I'd add a knob if that is deemed useful. I believe that most embedded implementations will dead strip everything away if they don't use it anyways, so that might never be an issue.
>
> Once this is shipped, we'll only be missing `from_chars`, right? We should be able to use https://github.com/fastfloat/fast_float to do that. We can ask if Daniel Lemire would relicense his code.

I'm pretty sure I can get the Abseil team to license absl::from_chars (https://abseil.io/about/design/charconv), if desired.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70631/new/

https://reviews.llvm.org/D70631