[libcxx-commits] [PATCH] D108855: [libcxx] contiguous iterator concept: don't require pointer or complete element types

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/test/std/iterators/iterator.requirements/iterator.concepts/iterator.concept.random.access/contiguous_iterator.verify.cpp:11
+// UNSUPPORTED: libcpp-no-concepts
+
+// template<class T>
----------------
jloser wrote:
> jloser wrote:
> > ldionne wrote:
> > > I was going to make some comments about things that need to change in this test, however now I'm not sure we need it at all. Do we really need to test that something that doesn't work doesn't work?
> > > 
> > > Things might be different if we were testing a specific failure diagnostic, but as it stands, I don't really understand what test coverage this is providing.
> > Right, I originally removed the test as I mentioned it was ill-formed due to the type missing an `element_type` type alias, but @cjdb wanted to keep the test.
> > 
> > @cjdb can you share some insight into the value you see in keeping this as a verification test?
> @ldionne see https://reviews.llvm.org/D108855?id=369228#inline-1037144 for some context on the previous discussion regarding this test.
That pretty much sums it up. I don't think there's another test that checks `std::to_address` is a hard requirement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108855/new/

https://reviews.llvm.org/D108855