[libcxx-commits] [PATCH] D108836: [libc++] Support -DLLVM_ENABLE_PER_TARGET_RUNTIME_DIR=on in CI

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

I'm somewhat concerned that we need to include two directories to properly handle libc++ here. I would prefer if we only needed to add `build/generic-cxx17/include/x86_64-unknown-linux-gnu/c++/v1`, i.e. the target-specific directory. Adding two directories is a change from how we've always done things in libc++. @phosek Was it intended that folks wouldn't be able to use libc++ without providing two include paths going forward?

Apart from that concern, the patch LGTM. Marking as "request changes" until we've resolved that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108836/new/

https://reviews.llvm.org/D108836