[libcxx-commits] [PATCH] D108927: [libc++][NFC] split <charconv>.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Aug 30 10:48:41 PDT 2021


Mordante created this revision.
Herald added a subscriber: mgorny.
Mordante requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This move the helper types `chars_format`, `to_chars_result` and
`from_chars_result` to a separate header. The first two are needed for
D70631 <https://reviews.llvm.org/D70631> the third for consistency.

The header `__charconv/ryu.h` uses these types and it can't depend on the
types in `<charconv>` in a modular build. Moving them to the ryu header
would be an odd place and doesn't work since the header is included in the
middle of `<charconv>`.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108927

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__charconv/chars_format.h
  libcxx/include/__charconv/from_chars_result.h
  libcxx/include/__charconv/to_chars_result.h
  libcxx/include/charconv
  libcxx/include/module.modulemap
  libcxx/test/libcxx/diagnostics/detail.headers/charconv/chars_format.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/charconv/from_chars_result.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/charconv/to_chars_result.module.verify.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108927.369491.patch
Type: text/x-patch
Size: 10867 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210830/552dee06/attachment-0001.bin>


More information about the libcxx-commits mailing list