[libcxx-commits] [PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Fri Aug 27 13:05:03 PDT 2021


MaskRay added a comment.

In D107799#2969787 <https://reviews.llvm.org/D107799#2969787>, @eugenis wrote:

> This breaks libc++ on the sanitizer bot in a similar way:
> https://lab.llvm.org/buildbot/#/builders/37/builds/6371
>
>   /b/sanitizer-x86_64-linux/build/symbolizer_build32/symbolizer/libcxx/include/c++/v1/__config:13:10: fatal error: '__config_site' file not found
>
> This line needs to add a target dir to the header path:
> https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/sanitizer_common/symbolizer/scripts/build_symbolizer.sh#L126

`LLVM_FLAGS="${FLAGS} -nostdinc++ -I${ZLIB_BUILD} -I${LIBCXX_BUILD}/include/c++/v1 -Wno-error=global-constructors"` should use a scheme similar to D108836 <https://reviews.llvm.org/D108836>.
@eugenis Can you make such a change to sanitizer bots?

Perhaps switch from `-I` to `-isystem` while touching the line.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107799/new/

https://reviews.llvm.org/D107799



More information about the libcxx-commits mailing list