[libcxx-commits] [PATCH] D107799: [CMake] Enable LLVM_ENABLE_PER_TARGET_RUNTIME_DIR by default on Linux

[Fangrui Song via Phabricator via libcxx-commits]

MaskRay updated this revision to Diff 369126.
MaskRay marked an inline comment as done.
MaskRay added a comment.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.

Add a blank line in libcxx/TODO.txt to trigger buildbot.

`libcxx/utils/ci/run-buildbot generic-cxx17` doesn't work on many Linux distro.
It uses `/usr/bin/c++` (g++) to compile tests which fail with:

`c++: error: unrecognized command-line option '-nostdlib++'; did you mean '-nostdlib'?`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107799/new/

https://reviews.llvm.org/D107799

Files:
  libcxx/TODO.TXT
  llvm/CMakeLists.txt


Index: llvm/CMakeLists.txt
===================================================================
--- llvm/CMakeLists.txt
+++ llvm/CMakeLists.txt
@@ -671,7 +671,12 @@
 set(LLVM_TARGET_TRIPLE_ENV CACHE STRING "The name of environment variable to override default target. Disabled by blank.")
 mark_as_advanced(LLVM_TARGET_TRIPLE_ENV)
 
-set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR OFF CACHE BOOL
+if(CMAKE_SYSTEM_NAME MATCHES "Linux")
+  set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default ON)
+else()
+  set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default OFF)
+endif()
+set(LLVM_ENABLE_PER_TARGET_RUNTIME_DIR ${LLVM_ENABLE_PER_TARGET_RUNTIME_DIR_default} CACHE BOOL
   "Enable per-target runtimes directory")
 
 set(LLVM_PROFDATA_FILE "" CACHE FILEPATH
Index: libcxx/TODO.TXT
===================================================================
--- libcxx/TODO.TXT
+++ libcxx/TODO.TXT
@@ -73,3 +73,4 @@
 * Document the "conditionally-supported" bits of libc++
 * Look at basic_string's move assignment operator, re LWG 2063 and POCMA
 * Put a static_assert in std::allocator to deny const/volatile types (LWG 2447)
+


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107799.369126.patch
Type: text/x-patch
Size: 1099 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210827/ad33a2df/attachment-0001.bin>