[libcxx-commits] [PATCH] D108829: [libc++] Various cleanups in the ranges tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne marked an inline comment as done.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/test/std/ranges/range.access/range.access.begin/incomplete.verify.cpp:23-25
 template <class T>
 requires(!std::invocable<begin_t&, T>)
 void f() {}
----------------
Quuxplusone wrote:
> It might be more to the point to make this an actual SFINAE situation, like
> ```
> template<class T> void f() requires std::invocable<begin_t&, T> {}
> template<class T> void f() {}
> ```
> https://godbolt.org/z/deP98eMvd
> 
> Also, calling this 48-line spew a "better" diagnostic is... generous. ;)
I'll suggest that we tackle whether or not we want this behavior at all as a separate patch.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108829/new/

https://reviews.llvm.org/D108829