[libcxx-commits] [PATCH] D108820: [libc++][NFC] Fix include guard for decay_copy.h and remove underscores from the header
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Fri Aug 27 08:40:56 PDT 2021
Quuxplusone added subscribers: Mordante, Quuxplusone.
Quuxplusone accepted this revision.
Quuxplusone added a comment.
This revision is now accepted and ready to land.
I'm happy assuming buildkite is happy!
FWIW, I do see two adjacent open questions, neither of which needs to be addressed in this PR:
- Should `<utility>` include `<__utility/decay_copy.h>`? (I have no preference, except for consistency, and even gaining consistency seems like it'll be a bit of an uphill effort)
- Should `decay_copy.h` really have that `// -*- C++ -*-` on line 1? @mordante has pointed out that the comment is useful (to certain syntax-highlighting editors) for //files with no extension//, such as `<string>`, but for `.h` and `.cpp` files I assume it has little benefit. Right now some `__foo/*.h` subdirectories are totally comment-less (`__compare`, `__concepts`, `__random`), some are totally comment-ful (`__format`, `__iterator`, `__memory`, `__ranges`), and some are mixed (`__functional`, `__utility`). Personally I prefer comment-less.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108820/new/
https://reviews.llvm.org/D108820
More information about the libcxx-commits
mailing list