[libcxx-commits] [PATCH] D108645: [libcxx] [NFCI] Complete helper concept

[Joe Loser via Phabricator via libcxx-commits]

jloser added a comment.

In D108645#2963230 <https://reviews.llvm.org/D108645#2963230>, @ldionne wrote:

> I think the value of this patch highly depends on whether we're right to look at the completeness of the type in `contiguous_iterator`. If not, then there's no duplication and I don't think this is worth pursuing. If so, then we can go forward but I'd find a different name too or try to make the concept really answer the question "is this type complete?", as Arthur mentioned.

Agreed. I'm going to wait to hear back from @zoecarver or @cjdb if we should remove the `complete` use in `__iterator/concepts.h`.

If it's correct to only look at complete types in `contiguous_iterator`, then I'll clean up the concept naming.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108645/new/

https://reviews.llvm.org/D108645