[libcxx-commits] [PATCH] D108668: [libc++] XFAIL align.pass.cpp for PowerPC LE

Amy Kwan via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 25 21:46:43 PDT 2021


amyk updated this revision to Diff 368803.
amyk added a comment.

Update the target to XFAIL and add a brief description that the test fails on Power.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108668/new/

https://reviews.llvm.org/D108668

Files:
  libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp


Index: libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp
===================================================================
--- libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp
+++ libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp
@@ -20,6 +20,12 @@
 // std::atomic when used with __attribute__((vector(X))).
 // XFAIL: gcc
 
+// This fails on PowerPC, as the LLIArr2 and Padding structs do not have
+// adequate alignment, despite these types returning true for the query of
+// being lock-free. This is an issue that occurs when linking in the
+// PowerPC GNU libatomic library into the test.
+// XFAIL: target=powerpc{{.*}}le-unknown-linux-gnu
+
 // <atomic>
 
 // Verify that the content of atomic<T> is properly aligned if the type is


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108668.368803.patch
Type: text/x-patch
Size: 760 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210826/25f0cb99/attachment.bin>


More information about the libcxx-commits mailing list