[libcxx-commits] [PATCH] D107584: [libc++][modularisation] Split up <concepts> into granular headers.

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Aug 25 15:20:52 PDT 2021


ldionne added a comment.

@Quuxplusone Indeed, please do not ever modify code in modularisation patches, it's akin to "sneaking in" changes. I'm sure that wasn't your intent, but let's be careful about that.

Please revert to using `std::forward` -- if we want to use `static_cast`, we'll do it consistently everywhere.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107584/new/

https://reviews.llvm.org/D107584



More information about the libcxx-commits mailing list