[libcxx-commits] [PATCH] D108575: [libcxx] Define insert_iterator::iter with ranges::iterator_t
Louis Dionne via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Aug 25 07:19:12 PDT 2021
ldionne accepted this revision as: ldionne.
ldionne added a comment.
LGTM with my and Arthur's comments applied, and CI passing.
Arthur, I'll let you give the final approval.
================
Comment at: libcxx/include/__iterator/insert_iterator.h:44
+ typename _Container::iterator iter;
+#endif // _LIBCPP_STD_VER > 17 && !defined(_LIBCPP_HAS_NO_RANGES)
+ public:
----------------
You can remove this comment - the `#if` is so small that we can easily see the condition when looking at the `#endif`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108575/new/
https://reviews.llvm.org/D108575
More information about the libcxx-commits
mailing list