[libcxx-commits] [PATCH] D108668: [libc++] XFAIL align.pass.cpp for PowerPC LE

[Amy Kwan via Phabricator via libcxx-commits]

amyk created this revision.
amyk added reviewers: jsji, hubert.reinterpretcast.
amyk added a project: libc++.
Herald added subscribers: steven.zhang, shchenz, jfb, nemanjai.
Herald added a reviewer: jfb.
amyk requested review of this revision.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

This patch XFAILs the `align.pass.cpp` for PowerPC (LE).

It appears that this test will fail on Power for the `LLIArr2` and `Padding` structs within the test, 
as the `assert` for `alignof(AtomicImpl) >= sizeof(AtomicImpl)` will be false. In this case, these structs 
presumably should not be lock-free, so we currently XFAIL this for now.

The failure was discovered after D97913 <https://reviews.llvm.org/D97913> was committed. It looks like `alignof(AtomicImpl) < sizeof(AtomicImpl)`,
even prior to this commit, but this test began running on Power after D97913 <https://reviews.llvm.org/D97913>, whereas we were
not running `align.pass.cpp` before.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108668

Files:
  libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp


Index: libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp
===================================================================
--- libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp
+++ libcxx/test/libcxx/atomics/atomics.align/align.pass.cpp
@@ -18,7 +18,7 @@
 
 // GCC currently fails because it needs -fabi-version=6 to fix mangling of
 // std::atomic when used with __attribute__((vector(X))).
-// XFAIL: gcc
+// XFAIL: gcc, powerpc64le, powerpcle
 
 // <atomic>
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108668.368481.patch
Type: text/x-patch
Size: 477 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210824/fe592fd7/attachment-0001.bin>