[libcxx-commits] [PATCH] D107895: [runtimes] Set more paths when building runtimes standalone

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D107895#2939733 <https://reviews.llvm.org/D107895#2939733>, @mstorsjo wrote:

> In D107895#2939546 <https://reviews.llvm.org/D107895#2939546>, @ldionne wrote:
>
>> Can you describe how you're running the build? Are you using the runtimes/ directory as the top-level directory?
>>
>> I don't want to support yet another way of building the runtimes, there's already too many. If we add this one, it has to be better than the other alternatives and fix some issues so that we can remove support for the other ways to build.
>
> I’m running the building by pointing cmake at either libcxx

That's the standalone build we're trying to get rid of, yeah.

> or the llvm-projects/runtimes directory

Do you mean using `llvm-projects/runtimes` as the top-level of the CMake invocation?

The supported ways to build libc++ are https://libcxx.llvm.org/BuildingLibcxx.html#the-default-build and https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build (and the standalone build, which is not documented anymore).

I'm not trying to push back on this change just for the sake of it, I'm really trying to understand whether this adds yet another way to build libc++ or not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107895/new/

https://reviews.llvm.org/D107895