[libcxx-commits] [PATCH] D108575: [libcxx] Define insert_iterator::iter with ranges::iterator_t

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Thanks for fixing this! As others have mentioned, please add a short test for this and I think it should be good to go.



================
Comment at: libcxx/include/__iterator/insert_iterator.h:40
     _Container* container;
-    typename _Container::iterator iter; // FIXME: `ranges::iterator_t<Container>` in C++20 mode
-public:
+#if _LIBCPP_STD_VER > 17
+    ranges::iterator_t<_Container> iter;
----------------
That should fix the CI issues you're seeing.

In the not-too-far future, we'll be able to drop `_LIBCPP_HAS_NO_RANGES` altogether, but for now we still support 1-2 compilers that don't implement concepts, and hence on which Ranges are not available.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108575/new/

https://reviews.llvm.org/D108575