[libcxx-commits] [PATCH] D108326: [SystemZ][z/OS] Fix handling of dirs with filesystem tests

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Also, you're submitting a patch for a platform that isn't supported. I very much want to support it, but in order to do so properly, I need something very simple: a build bot. Would it be possible to add one?



================
Comment at: libcxx/test/support/filesystem_test_helper.h:145
+        // permission change for directories that do not have read permission.
+        std::string cmd = "find  " + test_root.string() + " -exec chmod 777 {} \\;";
 #else
----------------
Can we unconditionally make this change?


================
Comment at: libcxx/test/support/filesystem_test_helper.h:152
 
-        cmd = "rm -r " + test_root.string();
+        cmd = "rm -rf " + test_root.string();
         ret = std::system(cmd.c_str());
----------------
Why add `f`?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108326/new/

https://reviews.llvm.org/D108326