[libcxx-commits] [PATCH] D108638: [libc++] Assume that compilers support extended constexpr in C++14 mode

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/include/__config:565-567
 #if _MSC_VER < 1900
 #error "MSVC versions prior to Visual Studio 2015 are not supported"
 #endif
----------------
ldionne wrote:
> Quuxplusone wrote:
> > Should this number be bumped upward? Or does `_MSC_VER==1900` actually support C++14 constexpr, and we just didn't notice it until now?
> > 
> > IIUC, this is a "major NFC" change ;) — we used to never use C++14 constexpr on `_LIBCPP_COMPILER_MSVC`, and now we're going to always use it. Right? (Not a "problem" per se, but noteworthy.)
> @mstorsjo Do you know what's the status of our support on MSVC? Officially, we don't support it, but does it actually work even a bit?
I remember seeing a mention somewhere, that the biggest blocker is that MSVC doesn't support `#include_next`, which pretty much blocks it from even trying to use our headers.

In this case, the MSVC version number here corresponds to the version of MSVC that clang-cl impersonates, and also implying what version of the MSVC runtime is being used.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108638/new/

https://reviews.llvm.org/D108638