[libcxx-commits] [PATCH] D42225: libcxx: Provide overloads for basic_filebuf::open() et al that take wchar_t* filenames on Windows.

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

In D42225#2962348 <https://reviews.llvm.org/D42225#2962348>, @ldionne wrote:

> @pcc @mstorsjo Are we aware of anyone using these extensions?
>
> I would like to suggest that we either remove this extension if it's not useful, or make it unconditional (not only on Windows) if we really think it's that useful (but I'd like that to come with at least a paper proposing to add them to the standard). Carrying around an extension that's only enabled on one platform (and not the most widely used platform for libc++ at that) is kind of awkward.

This extension is fairly essential - without it, you can't interact with files that have names outside of the 8 bit charset on Windows (and exactly what the 8 bit charset is, can vary from system to system). I can't point to a specific user of it, but I'd expect there to be numerous out there.

Making it universally available sounds like a sensible strategy forward - although I don't think I have the bandwidth to take on making it a standards proposal. Maybe someone from Microsoft (who invented this extension) can collaborate on it?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D42225/new/

https://reviews.llvm.org/D42225