[libcxx-commits] [PATCH] D105968: [libunwind][CET] Support exception handling stack unwind in CET environment

Fangrui Song via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 24 12:33:55 PDT 2021


MaskRay added a comment.

In D105968#2962009 <https://reviews.llvm.org/D105968#2962009>, @xiongji90 wrote:

> In D105968#2961508 <https://reviews.llvm.org/D105968#2961508>, @MaskRay wrote:
>
>> There are still many unresolved comments. Please mark resolved ones as done and then click "Submit".
>
> Hi, @MaskRay 
> Left unresolved comments are resolved and I also rebased the patch to latest llvm libunwind code.
>
> Thanks very much.

You marked your own comments as "Done" but not reviewers' comments as "Done".

So I currently see 35 among 79 comments are done, while the rest are not.

Please mark resolved ones as done.

If you need a reviewer to commit this patch on your behalf, please provide `git commit --amend --author="name <email>"`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105968/new/

https://reviews.llvm.org/D105968



More information about the libcxx-commits mailing list