[libcxx-commits] [PATCH] D108638: [libc++] Assume that compilers support extended constexpr in C++14 mode

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added a comment.

LGTM % if there's anything to do about my comment.



================
Comment at: libcxx/include/__config:565-567
 #if _MSC_VER < 1900
 #error "MSVC versions prior to Visual Studio 2015 are not supported"
 #endif
----------------
Should this number be bumped upward? Or does `_MSC_VER==1900` actually support C++14 constexpr, and we just didn't notice it until now?

IIUC, this is a "major NFC" change ;) — we used to never use C++14 constexpr on `_LIBCPP_COMPILER_MSVC`, and now we're going to always use it. Right? (Not a "problem" per se, but noteworthy.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108638/new/

https://reviews.llvm.org/D108638