[libcxx-commits] [PATCH] D108632: [libc++] Remove workaround for missing declarations on Windows store apps

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Aug 24 07:41:21 PDT 2021


ldionne created this revision.
ldionne added a reviewer: smeenai.
ldionne requested review of this revision.
Herald added a project: libc++.
Herald added a subscriber: libcxx-commits.
Herald added a reviewer: libc++.

We don't need preprocessor logic to exclude those declarations when compiling for
the Windows App Store, because that is handled by using_if_exists now.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D108632

Files:
  libcxx/include/__config
  libcxx/include/cstdlib


Index: libcxx/include/cstdlib
===================================================================
--- libcxx/include/cstdlib
+++ libcxx/include/cstdlib
@@ -129,10 +129,8 @@
 using ::atexit _LIBCPP_USING_IF_EXISTS;
 using ::exit _LIBCPP_USING_IF_EXISTS;
 using ::_Exit _LIBCPP_USING_IF_EXISTS;
-#ifndef _LIBCPP_WINDOWS_STORE_APP
 using ::getenv _LIBCPP_USING_IF_EXISTS;
 using ::system _LIBCPP_USING_IF_EXISTS;
-#endif
 using ::bsearch _LIBCPP_USING_IF_EXISTS;
 using ::qsort _LIBCPP_USING_IF_EXISTS;
 using ::abs _LIBCPP_USING_IF_EXISTS;
Index: libcxx/include/__config
===================================================================
--- libcxx/include/__config
+++ libcxx/include/__config
@@ -298,17 +298,6 @@
 #    define _LIBCPP_HAS_QUICK_EXIT
 #  endif
 
-// Some CRT APIs are unavailable to store apps
-#  if defined(WINAPI_FAMILY)
-#    include <winapifamily.h>
-#    if !WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_DESKTOP) &&                  \
-        (!defined(WINAPI_PARTITION_SYSTEM) ||                                  \
-         !WINAPI_FAMILY_PARTITION(WINAPI_PARTITION_SYSTEM))
-#      define _LIBCPP_WINDOWS_STORE_APP
-#    endif
-#  endif
-#endif // defined(_WIN32)
-
 #ifdef __sun__
 #  include <sys/isa_defs.h>
 #  ifdef _LITTLE_ENDIAN


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D108632.368343.patch
Type: text/x-patch
Size: 1258 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210824/be5f9b9a/attachment.bin>


More information about the libcxx-commits mailing list