[libcxx-commits] [PATCH] D105968: [libunwind][CET] Support exception handling stack unwind in CET environment

[xiongji90 via Phabricator via libcxx-commits]

xiongji90 added inline comments.


================
Comment at: libunwind/src/UnwindCursor.hpp:456
+  virtual void *get_registers() {
+    _LIBUNWIND_ABORT("cet_jumpto not implemented");
+  }
----------------
compnerd wrote:
> Most of the warnings indicate the name.  I would suggest we follow the same convention to help quickly identify the function which is unimplemented.
Done.

Thanks very much.


================
Comment at: libunwind/src/UnwindLevel1.c:57-58
+                     "jmp *%%edx\n\t" ::"D"(cetRegContext),                    \
+                     "d"(cetJumpAddress)                                       \
+                     :);                                                       \
+  } while (0)
----------------
compnerd wrote:
> 
Done.

Thanks very much.


================
Comment at: libunwind/src/UnwindLevel1.c:67-68
+    __asm__ volatile("jmpq *%%rdx\n\t" ::"D"(cetRegContext),                   \
+                     "d"(cetJumpAddress)                                       \
+                     :);                                                       \
+  } while (0)
----------------
compnerd wrote:
> 
Done.

Thanks very much.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105968/new/

https://reviews.llvm.org/D105968