[libcxx-commits] [PATCH] D103478: [libc++][compare] Implement three_way_comparable[_with] concepts

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb accepted this revision.
cjdb added a comment.
This revision is now accepted and ready to land.

Also LGTM, but since I'm not a co-approver, we'll need to wait for either @ldionne's approval or a second co-approver.



================
Comment at: libcxx/include/__compare/three_way_comparable.h:12-16
+#include <__compare/common_comparison_category.h>
+#include <__concepts/equality_comparable.h>
+#include <__concepts/totally_ordered.h>
+#include <__config>
+#include <type_traits>
----------------
Quuxplusone wrote:
> You're missing some IWYU here, e.g. `same_as.h`. You need to include these directly, for the benefit of the Modules build; it's not Modules-kosher to rely on the fact that `totally_ordered.h` happens to include `same_as.h`.
> Check D107036 for the complete listing.
> 
For future reference: running `bin/llvm-lit -sv /path/to/llvm-project/libcxx/test/ --param enable_modules=True` will catch this for you.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103478/new/

https://reviews.llvm.org/D103478