[libcxx-commits] [PATCH] D105968: [libunwind][CET] Support exception handling stack unwind in CET environment

[xiongji90 via Phabricator via libcxx-commits]

xiongji90 added a comment.

Hi, @compnerd and @MaskRay 
I just updated the patch to fix some code format/comments issue, do I need your approval again to commit this patch?
Thanks very much.



================
Comment at: libunwind/CMakeLists.txt:188
+  if (NOT LIBUNWIND_SUPPORTS_FCF_PROTECTION_EQ_FULL_FLAG)
+    message(FATAL_ERROR "Compiler doesn't support CET -fcf-protection option!")
+  endif()
----------------
compnerd wrote:
> I would recommend `SEND_ERROR` here instead of `FATAL_ERROR`.  This will allow getting subsequent errors as well.
Done.

Thanks very much.


================
Comment at: libunwind/CMakeLists.txt:191
+  if (NOT LIBUNWIND_SUPPORTS_MSHSTK_FLAG)
+    message(FATAL_ERROR "Compiler doesn't support CET -mshstk option!")
+  endif()
----------------
compnerd wrote:
> I would recommend `SEND_ERROR` here instead of `FATAL_ERROR`.
Done.

Thanks very much.


================
Comment at: libunwind/src/cet_unwind.h:10-11
+
+#ifndef _CET_UNWIND_H_
+#define _CET_UNWIND_H_
+
----------------
compnerd wrote:
> 
Done.

Thanks very much.


================
Comment at: libunwind/src/cet_unwind.h:17
+
+// Currently, CET is implemented on Linux x86 platform.
+#if defined(_LIBUNWIND_TARGET_LINUX) && defined(__CET__) && defined(__SHSTK__)
----------------
compnerd wrote:
> 
Done.

Thanks very much.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105968/new/

https://reviews.llvm.org/D105968