[libcxx-commits] [PATCH] D107036: [WIP] [libc++] [P1614] Various unimplemented parts of <compare>. [WIP]

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone updated this revision to Diff 367673.
Quuxplusone edited the summary of this revision.
Quuxplusone added a comment.

Rebased on main, to show what's left to do.
Tried a new bit-twiddling version of IEC559 `totalOrder`. Unfortunately I still don't know how to test it or how to make it constexpr. Fortunately, C++20 requires that it //not// be constexpr, AFAICT? See https://eel.is/c++draft/cmp#alg-1 which doesn't mention `constexpr` either positively or negatively.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107036/new/

https://reviews.llvm.org/D107036

Files:
  libcxx/include/CMakeLists.txt
  libcxx/include/__compare/cmp_alg.h
  libcxx/include/__compare/compare_three_way.h
  libcxx/include/__compare/three_way_comparable.h
  libcxx/include/__utility/priority_tag.h
  libcxx/include/compare
  libcxx/include/functional
  libcxx/include/module.modulemap
  libcxx/include/utility
  libcxx/test/libcxx/diagnostics/detail.headers/compare/cmp_alg.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/compare/compare_three_way.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/compare/three_way_comparable.module.verify.cpp
  libcxx/test/libcxx/diagnostics/detail.headers/utility/priority_tag.module.verify.cpp
  libcxx/test/std/language.support/cmp/cmp.alg/strong_order.pass.cpp
  libcxx/test/std/language.support/cmp/cmp.concept/three_way_comparable.compile.pass.cpp
  libcxx/test/std/language.support/cmp/cmp.concept/three_way_comparable_with.compile.pass.cpp
  libcxx/test/std/library/description/conventions/type.descriptions/customization.point.object/cpo.pass.cpp
  libcxx/test/std/utilities/function.objects/comparisons/compare_three_way.pass.cpp
  libcxx/test/std/utilities/function.objects/comparisons/transparent.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107036.367673.patch
Type: text/x-patch
Size: 45905 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210820/9574cd81/attachment-0001.bin>