[libcxx-commits] [PATCH] D108352: [PowerPC] Fix a test case failure when compiled with libcxx

[Albion Fung via Phabricator via libcxx-commits]

Conanap marked an inline comment as done.
Conanap added inline comments.


================
Comment at: libcxx/test/std/numerics/numeric.ops/numeric.ops.midpoint/midpoint.float.pass.cpp:95
 
-#if defined(__PPC__) && __LONG_DOUBLE_128__ && !__LONG_DOUBLE_IEEE128__
+#if defined(__PPC__) && __LONG_DOUBLE_128__ && (!defined(__LONG_DOUBLE_IEEE128__) || !__LONG_DOUBLE_IEEE128__)
 //	For 128 bit long double implemented as 2 doubles on PowerPC,
----------------
Quuxplusone wrote:
> Please De-Morgan-ize this condition, for readability. Make it:
> ```
> #if defined(__PPC__) && __LONG_DOUBLE_128__ && !(defined(__LONG_DOUBLE_IEEE128__) && __LONG_DOUBLE_IEEE128__)
> ```
updated, thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108352/new/

https://reviews.llvm.org/D108352