[libcxx-commits] [PATCH] D107996: [libunwind] Rename UNW_ARM64_* to UNW_AARCH64_*

Fri Aug 20 14:17:39 PDT 2021

compnerd accepted this revision.
compnerd added a comment.
This revision is now accepted and ready to land.

I'll assume that you caught all the instances of `_ARM64_` when you switched the usage to the `_AARCH64_` spelling.  I think it may be nicer to keep the current spelling as the default, but it doesn't really matter to the users.

================
Comment at: libunwind/include/libunwind.h:532
+  UNW_AARCH64_PC = 32,
   // reserved block
+  UNW_AARCH64_RA_SIGN_STATE = 34,
----------------
Wouldn't mind a new line before this block either.

================
Comment at: libunwind/include/libunwind.h:569
+
+  UNW_ARM64_X0 = UNW_AARCH64_X0,
+  UNW_ARM64_X1 = UNW_AARCH64_X1,
----------------
Might be nice to have a comment like `// Compatibility aliases` or something.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107996/new/

https://reviews.llvm.org/D107996