[libcxx-commits] [PATCH] D108321: [SystemZ][z/OS] Avoid assumption for character value in futures tests

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 19 18:29:57 PDT 2021


Quuxplusone accepted this revision.
Quuxplusone added a subscriber: ldionne.
Quuxplusone added a comment.
This revision is now accepted and ready to land.

It's because I accepted as "Quuxplusone" but not as "libc++"; normally we like to get an OK from two libc++ reviewers (and/or @ldionne) before granting the "libc++" project approval.
Anyway, I think this is obviously fine, so while I encourage you to wait for someone else's rubber-stamp, I'm also going to just mark it accepted anyway, so even if nobody new looks at it you won't be blocked.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108321/new/

https://reviews.llvm.org/D108321



More information about the libcxx-commits mailing list