[libcxx-commits] [PATCH] D108071: [libcxx] Improve testing in #ifdef.

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 19 11:44:41 PDT 2021


Mordante abandoned this revision.
Mordante added a comment.

In D108071#2954872 <https://reviews.llvm.org/D108071#2954872>, @Conanap wrote:

> In D108071#2954864 <https://reviews.llvm.org/D108071#2954864>, @Mordante wrote:
>
>> @Conanap I'm a bit confused now. Do you want me to fix this patch or do you want to land your patch?
>
> My patched is preferred here, thanks! I appreciate the work you put in though.

No problem, but next time it would be easier to just add review comments to an existing review instead of creating a new review.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108071/new/

https://reviews.llvm.org/D108071



More information about the libcxx-commits mailing list