[libcxx-commits] [PATCH] D108384: [libc++][NFCI] Remove unnecessary exception-throwing base classes

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added inline comments.


================
Comment at: libcxx/include/deque:915-916
-protected:
-    _LIBCPP_NORETURN void __throw_length_error() const;
-    _LIBCPP_NORETURN void __throw_out_of_range() const;
-};
----------------
Quuxplusone wrote:
> I notice these were never `_LIBCPP_HIDE_FROM_ABI` or whatever. But that's fine, right? I believe I agree that this PR doesn't cause an ABI break in any interesting sense.
Yes, that should be fine. Anyone using these functions had a weak-definition in their TU, which the linker deduped across TUs (based on the ODR). Now we're just removing those, so that new code compiled against the new headers won't need or generate those weak definitions. It would be a risk of ODR-violation if we changed the definition of these functions because existing code was compiled with one definition and new code would be compiled with a new definition, but that's not what we're doing here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108384/new/

https://reviews.llvm.org/D108384