[libcxx-commits] [PATCH] D108384: [libc++][NFCI] Remove unnecessary exception-throwing base classes

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 19 09:57:06 PDT 2021


Quuxplusone accepted this revision as: Quuxplusone.
Quuxplusone added inline comments.


================
Comment at: libcxx/include/deque:915-916
-protected:
-    _LIBCPP_NORETURN void __throw_length_error() const;
-    _LIBCPP_NORETURN void __throw_out_of_range() const;
-};
----------------
I notice these were never `_LIBCPP_HIDE_FROM_ABI` or whatever. But that's fine, right? I believe I agree that this PR doesn't cause an ABI break in any interesting sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108384/new/

https://reviews.llvm.org/D108384



More information about the libcxx-commits mailing list